Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faker-js 更新に伴う修正 #531

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Mar 16, 2022

  • Apply yarn upgrade --latest #527
  • @faker-js/faker の導入に伴い、エラーになったテストを修正
  • tracing.startChunk: Tracing is already stopping のエラーになるため、 trace: 'off' に設定

@codecov-commenter
Copy link

Codecov Report

Merging #531 (d143f7f) into master (1cb56c7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #531   +/-   ##
=======================================
  Coverage   54.53%   54.53%           
=======================================
  Files          76       76           
  Lines        9065     9065           
=======================================
  Hits         4944     4944           
  Misses       4121     4121           
Flag Coverage Δ
tests 54.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb56c7...d143f7f. Read the comment docs.

以下のエラーとなってしまう場合がある

> tracing.startChunk: Tracing is already stopping
@chihiro-adachi chihiro-adachi merged commit a9afab7 into EC-CUBE:master Mar 23, 2022
@nanasess nanasess deleted the fix-faker branch October 3, 2022 08:22
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants